Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8634] Add new option to edit changes in saved search or save as new #4229

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

MichalKinas
Copy link
Contributor

@MichalKinas MichalKinas commented Nov 7, 2024

https://hyland.atlassian.net/browse/ACS-8634

Previously there was no option to edit params of saved search, now when user navigates from saved search we can choose to either save changes or save new search.
Added also validation to check if saved search name is unique.

@AleksanderSklorz
Copy link
Contributor

I found strange issue that sometimes arrow to expand navbar is disappeared when navbar is collapsed so I can't show navbar again

Screen.Recording.2024-11-07.at.15.25.12.mov

@AleksanderSklorz
Copy link
Contributor

Is that expected behavior? When I edit some search and save it as new and then I want to edit this new search then I have no 2 options like "Save changes" and "Save as new". I have only single option. I can imagine somebody may want to have option to save it as new or to modify existing one but actually there is no option

Screen.Recording.2024-11-07.at.15.27.27.mov

@AleksanderSklorz
Copy link
Contributor

I see multiple issues in case when you edit saved search with duplicated configuration. See below video:

Screen.Recording.2024-11-07.at.15.35.57.mov

There I have two saved searches which search for "c". When I select one of them then both are highlighted (what is caused by the same url but it's ok). The problems are following:

  • if you edit one of them then when you for example refresh page then changes are not saved and you can see state before editing
  • initially both are highlighted after selecting one of them because of the same configuration but I guess when the configuration is edited then only one should be highlighted as they don't have the same config anymore?
  • I'm editing only one of them so theoretically I can expect that only one will be edited but initially before refresh you can see that both searches have new edited config instead of only that one which I clicked

@AleksanderSklorz
Copy link
Contributor

When I create new saved search then save button is disabled until I do something. When I edit saved search - button is always enabled even if I didn't do any changes. I can imagine case that somebody may want to have option to "save as new" without doing changes (for example somebody want's to copy saved search) but there is probably no reason to allow to save search without changes. Maybe it has sense to display only one option (save as new) when there is no changes?

Screen.Recording.2024-11-07.at.15.42.50.mov

@MichalKinas
Copy link
Contributor Author

I found strange issue that sometimes arrow to expand navbar is disappeared when navbar is collapsed so I can't show navbar again

Screen.Recording.2024-11-07.at.15.25.12.mov

It's fixed now

@MichalKinas
Copy link
Contributor Author

Is that expected behavior? When I edit some search and save it as new and then I want to edit this new search then I have no 2 options like "Save changes" and "Save as new". I have only single option. I can imagine somebody may want to have option to save it as new or to modify existing one but actually there is no option

Screen.Recording.2024-11-07.at.15.27.27.mov

Right now you will still have 2 options to either save as new or to save changes but in the original saved search since you didn't navigate to new one which is expected

@MichalKinas
Copy link
Contributor Author

I see multiple issues in case when you edit saved search with duplicated configuration. See below video:

Screen.Recording.2024-11-07.at.15.35.57.mov
There I have two saved searches which search for "c". When I select one of them then both are highlighted (what is caused by the same url but it's ok). The problems are following:

  • if you edit one of them then when you for example refresh page then changes are not saved and you can see state before editing
  • initially both are highlighted after selecting one of them because of the same configuration but I guess when the configuration is edited then only one should be highlighted as they don't have the same config anymore?
  • I'm editing only one of them so theoretically I can expect that only one will be edited but initially before refresh you can see that both searches have new edited config instead of only that one which I clicked

As far as I remember during the x-in-a-box we assumed that nobody will save exactly the same search so this is not covered right now, we can talk to Arabella if we want to cover this case and plan it as improvement in next RT if so

@MichalKinas
Copy link
Contributor Author

When I create new saved search then save button is disabled until I do something. When I edit saved search - button is always enabled even if I didn't do any changes. I can imagine case that somebody may want to have option to "save as new" without doing changes (for example somebody want's to copy saved search) but there is probably no reason to allow to save search without changes. Maybe it has sense to display only one option (save as new) when there is no changes?

Screen.Recording.2024-11-07.at.15.42.50.mov

This is expected since the only condition to be able to save is valid encoded query, that's why you need to perform any search before you'll be able to save any changes

Copy link

sonarqubecloud bot commented Nov 7, 2024

@AleksanderSklorz
Copy link
Contributor

I found strange issue that sometimes arrow to expand navbar is disappeared when navbar is collapsed so I can't show navbar again
Screen.Recording.2024-11-07.at.15.25.12.mov

It's fixed now

this issue still exists but as we discussed on slack - it will be fixed in separated task as this issue is not related with changes for Saved Searches

@MichalKinas MichalKinas merged commit a74d189 into develop Nov 8, 2024
25 checks passed
@MichalKinas MichalKinas deleted the feature/dev-mkinas-ACS-8634-editing branch November 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants