-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8634] Add new option to edit changes in saved search or save as new #4229
Conversation
projects/aca-content/src/lib/components/search/search-results/search-results.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/search/search-results/search-results.component.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/search/search-results/search-results.component.ts
Outdated
Show resolved
Hide resolved
...tent/src/lib/components/search/search-save/dialog/edit/saved-search-edit-dialog.component.ts
Show resolved
Hide resolved
...cts/aca-content/src/lib/components/search/search-save/dialog/unique-search-name-validator.ts
Show resolved
Hide resolved
projects/aca-content/src/lib/components/search/search-results/search-results.component.spec.ts
Outdated
Show resolved
Hide resolved
...ca-content/src/lib/components/search/search-save/dialog/unique-search-name-validator.spec.ts
Outdated
Show resolved
Hide resolved
I found strange issue that sometimes arrow to expand navbar is disappeared when navbar is collapsed so I can't show navbar again Screen.Recording.2024-11-07.at.15.25.12.mov |
Is that expected behavior? When I edit some search and save it as new and then I want to edit this new search then I have no 2 options like "Save changes" and "Save as new". I have only single option. I can imagine somebody may want to have option to save it as new or to modify existing one but actually there is no option Screen.Recording.2024-11-07.at.15.27.27.mov |
I see multiple issues in case when you edit saved search with duplicated configuration. See below video: Screen.Recording.2024-11-07.at.15.35.57.movThere I have two saved searches which search for "c". When I select one of them then both are highlighted (what is caused by the same url but it's ok). The problems are following:
|
When I create new saved search then save button is disabled until I do something. When I edit saved search - button is always enabled even if I didn't do any changes. I can imagine case that somebody may want to have option to "save as new" without doing changes (for example somebody want's to copy saved search) but there is probably no reason to allow to save search without changes. Maybe it has sense to display only one option (save as new) when there is no changes? Screen.Recording.2024-11-07.at.15.42.50.mov |
It's fixed now |
Right now you will still have 2 options to either save as new or to save changes but in the original saved search since you didn't navigate to new one which is expected |
As far as I remember during the x-in-a-box we assumed that nobody will save exactly the same search so this is not covered right now, we can talk to Arabella if we want to cover this case and plan it as improvement in next RT if so |
This is expected since the only condition to be able to save is valid encoded query, that's why you need to perform any search before you'll be able to save any changes |
Quality Gate passedIssues Measures |
this issue still exists but as we discussed on slack - it will be fixed in separated task as this issue is not related with changes for Saved Searches |
https://hyland.atlassian.net/browse/ACS-8634
Previously there was no option to edit params of saved search, now when user navigates from saved search we can choose to either save changes or save new search.
Added also validation to check if saved search name is unique.